[Kde-pim] Review Request: Support for message indicator in KMail

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2060/#review3086
-----------------------------------------------------------

Ship it!


> Would it make sense to move showKMail() and hideKMail() to KMKernel?

Yeah, would probably make sense, can't think of a better place right now.

Please make that change and the style fix change and commit.


trunk/KDE/kdepim/kmail/kmfolder.cpp
<http://reviewboard.kde.org/r/2060/#comment2515>

    Hey, there are still missing spaces here and in the next 2 function definitions


- Thomas


On 2009-11-12 23:36:34, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2060/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 23:36:34)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch adds optional support for message indicator to KMail. For more information about message indicators, have a look at this blog post: http://agateau.wordpress.com/2009/09/18/indicators-notifications-and-co/
> 
> You need libindicate and libindicate-qt installed to build it. You also need the indicator plasmoid at runtime otherwise you won't see anything interesting.
> - http://launchpad.net/libindicate
> - http://launchpad.net/libindicate-qt
> - http://launchpad.net/plasma-indicatordisplay
> 
> The patch is quite large, it is also available as more incremental steps here if you find this easier to read: http://people.canonical.com/~agateau/indicate/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/CMakeLists.txt 1048189 
>   trunk/KDE/kdepim/kmail/config-kmail.h.cmake 1048189 
>   trunk/KDE/kdepim/kmail/configuredialog.cpp 1048189 
>   trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1048189 
>   trunk/KDE/kdepim/kmail/kmfolder.h 1048189 
>   trunk/KDE/kdepim/kmail/kmfolder.cpp 1048189 
>   trunk/KDE/kdepim/kmail/kmkernel.h 1048189 
>   trunk/KDE/kdepim/kmail/kmkernel.cpp 1048189 
>   trunk/KDE/kdepim/kmail/ui/accountspagereceivingtab.ui 1048189 
> 
> Diff: http://reviewboard.kde.org/r/2060/diff
> 
> 
> Testing
> -------
> 
> This patch has been in use during Kubuntu Karmic development and is now deployed with Kubuntu Karmic version of KMail (kdepim 4.3.2 at the time of this writing).
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/