[Kde-pim] Review Request: knarticlefactory.cpp:205: warning: unused variable 'mbox'

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2216/#review3168
-----------------------------------------------------------



/trunk/KDE/kdepim/knode/knarticlefactory.cpp
<http://reviewboard.kde.org/r/2216/#comment2533>

    this looks strange. mbox is the loop's main variable, if it is not used there is something wrong with the loop.
    
    my guess is that it should be
    art->to()->addAdress(mbox);


- Kevin


On 2009-11-19 17:58:27, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2216/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 17:58:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/knode/knarticlefactory.cpp:205: warning: unused variable 'mbox'
> 
> at
> KNArticleFactory::createReply
> 
> my proposal: add Q_UNUSED( mbox)
> see: knarticlefactory-gm-83.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knarticlefactory.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2216/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/