[Kde-pim] Review Request: fakemonitor.cpp:49: warning: many enumeration values not handled

[Stephen Kelly]

> On 2009-11-09 11:34:06, Kevin Krammer wrote:
> > The FakeMonitor seems to be only used by the EntityTreeModel test.
> > 
> > While the default case certainly makes the compiler warning go away, I wonder whether the model test doesn't need to test handling of the other signals as well.
> > I which case the warning hints at an incomplete test and should probably stay in.

Yes, I intend to work more on those tests from early next week.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2095/#review2989
-----------------------------------------------------------


On 2009-11-08 15:25:13, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2095/
> -----------------------------------------------------------
> 
> (Updated 2009-11-08 15:25:13)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollecionUnMonitored' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollectionMonitored' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollectionStatisticsChanged' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollectionsChanged' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollectionsMoved' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'CollectionsRemoved' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemLinked' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemUnlinked' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemsAdded' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemsChanged' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemsMoved' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ItemsRemoved' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'MimetypeMonitored' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'MimetypeUnMonitored' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ResourceMonitored' not handled in switch
> /.../kdepimlibs/akonadi/tests/fakemonitor.cpp:49: warning: enumeration value 'ResourceUnMonitored' not handled in switch
> 
> at
> FakeMonitor::processNextEvent()
> 
> my proposal: complete with default case.
> see: fakemonitor-gm-42.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/tests/fakemonitor.cpp 1045694 
> 
> Diff: http://reviewboard.kde.org/r/2095/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/