[Kde-pim] Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch

[Guy Maurel]

> On 2009-11-05 19:01:11, Bertjan Broeksema wrote:
> > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp, line 639
> > <http://reviewboard.kde.org/r/1906/diff/2/?file=13119#file13119line639>
> >
> >     I would say that you should return "none" here. That seems the best option when looking at NeedsAction.

I would like to propose somethings else!
Have a look to my calls 1902 and 1906.
It is the same problem/question. And have a look 3 lines after. The author has allready an idea what is to do, but place this at a not very good place. Within the switch should be better.
BUT:
why do we have two files with nearly the same code? Some functions are really the same!
Should it be better to try to do a "merge"?


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1906/#review2940
-----------------------------------------------------------


On 2009-10-21 19:01:28, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1906/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 19:01:28)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch
> 
> at
> static QString attendeeStatusToString( KCal::Attendee::PartStat status )
> 
> my proposal:add the enumeration value 'None' in the switch
> see: incidence-gm-21.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 
> 
> Diff: http://reviewboard.kde.org/r/1906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/