[Kde-pim] Review Request: kconfigbasedkeyfilter.cpp:305: warning: suggest parentheses around && within ||

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2146/#review3185
-----------------------------------------------------------

Ship it!


This is fine.

- Stephen


On 2009-11-12 17:52:25, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2146/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 17:52:25)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/libkleo/kleo/kconfigbasedkeyfilter.cpp:305: warning: suggest parentheses around && within ||
> 
> at
> KeyFilterImplBase::matches
> 
> my proposal: complete with some more parentheses
> see: kconfigbasedkeyfilter-gm-57.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkleo/kleo/kconfigbasedkeyfilter.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2146/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/