[Kde-pim] Review Request: cryptoconfigmodule.cpp:844: warning: 'KUrl::List strings2urls ... ' defined but not used

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2150/#review3092
-----------------------------------------------------------

Ship it!


Simply remove them instead of commenting them out, then commit.

- Thomas


On 2009-11-12 18:08:35, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2150/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 18:08:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/libkleo/ui/cryptoconfigmodule.cpp:844: warning: 'KUrl::List strings2urls ... ' defined but not used
> /.../kdepim/libkleo/ui/cryptoconfigmodule.cpp:852: warning: 'QStringList urls2strings ... ' defined but not used
> 
> my proposal: as this functions are not defined in the cryptoconfigmodule.h, comment them out, until someone needs them.
> see: cryptoconfigmodule-gm-61.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkleo/ui/cryptoconfigmodule.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2150/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/