[Kde-pim] Review Request: amazingcompleter.cpp:115: warning: unused parameter 'end', 'parent', 'start' and 'handler'

[Guy Maurel]

> On 2009-11-20 16:58:05, Stephen Kelly wrote:
> > /trunk/KDE/kdepim/akonadi/akonadi_next/amazingcompleter.cpp, line 140
> > <http://reviewboard.kde.org/r/2217/diff/2/?file=14702#file14702line140>
> >
> >     Please do not commit this line.
> >     
> >     This is code that is not yet complete, so the warning is valid.

OK, done


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2217/#review3194
-----------------------------------------------------------


On 2009-11-23 17:40:51, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2217/
> -----------------------------------------------------------
> 
> (Updated 2009-11-23 17:40:51)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> the dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'end'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'parent'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'start'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:137: warning: unused parameter 'handler'
> 
> my proposal: add some Q_UNUSED( )
> see: amazingcompleter-gm-84.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/akonadi_next/amazingcompleter.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/