[Kde-pim] Review Request: speechclient.cpp:139: warning: unused parameter 'appId'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2223/#review3197
-----------------------------------------------------------



/trunk/KDE/kdepim/akregator/src/speechclient.cpp
<http://reviewboard.kde.org/r/2223/#comment2545>

    This appears to be a valid warning about incomplete code. Probably best to leave it.



/trunk/KDE/kdepim/akregator/src/speechclient.cpp
<http://reviewboard.kde.org/r/2223/#comment2546>

    I don't know this code, but it looks like this too might simply indicate incomplete code.


- Stephen


On 2009-11-19 18:53:40, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2223/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 18:53:40)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akregator/src/speechclient.cpp:139: warning: unused parameter 'appId'
> /.../kdepim/akregator/src/speechclient.cpp:76: warning: unused parameter 'language'
> 
> my proposal: add some Q_UNUSED( )
> see: speechclient-gm-90.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akregator/src/speechclient.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2223/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/