[Kde-pim] Review Request: alarmcalendar.cpp:541: warning: unused parameter 'resource'

[Stephen Kelly]

> On 2009-11-20 17:48:54, Stephen Kelly wrote:
> > Instead of filling this with TODOs, can we find out what should be in the implementation and write the implementation instead?
> > 
> > I must say I'm a bit confused by the code, as there are several places where it is directly called in that class with the success parameter set to false, eg when a cache fetch is completed.
> > 
> > I don't know why it is called that way, but perhaps djarvie can shed some light on what the implementation of that method should look like.

Ah, obviously I started writing this before I saw the comment from David.

In general though with all these review requests you are making, I personally think the time would be better spent figuring out if empty methods should be removed, implementing methods with unused parameters which are simply incomplete, and using Q_UNUSED for the rest.

If we're going to just silence all noise from valid compiler warnings, we might as well just turn them off. Just to be clear, I don't support turning off the warnings, but fixing the issue they point to.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2234/#review3204
-----------------------------------------------------------


On 2009-11-20 17:21:52, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2234/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 17:21:52)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kalarm/alarmcalendar.cpp:541: warning: unused parameter 'resource'
> 
> at
> AlarmCalendar::slotResourceLoaded
> 
> my proposal: add some Q_UNUSED( )
> see: alarmcalendar-gm-92.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kalarm/alarmcalendar.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2234/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/