[Kde-pim] Review Request: Migrate color settings in KMail to KConfigXT

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2271/#review3244
-----------------------------------------------------------



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/2271/#comment2565>

    Some one have a better way of doing this part?



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/2271/#comment2566>

    Same here, do not like to use mColorList->color(xx)



/trunk/KDE/kdepim/kmail/kmail.kcfg.cmake
<http://reviewboard.kde.org/r/2271/#comment2567>

    Can I do it like this? That is create a variable here that is then used in later entries.


- Torgny


On 2009-11-23 18:07:17, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2271/
> -----------------------------------------------------------
> 
> (Updated 2009-11-23 18:07:17)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Migrate the color settings in KMail to using KConfigXT. Patch should probably be ported to the messageviewer as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1053083 
>   /trunk/KDE/kdepim/kmail/csshelper.cpp 1053083 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 1053083 
>   /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1053083 
>   /trunk/KDE/kdepim/kmail/messagelistview/storagemodel.cpp 1053083 
> 
> Diff: http://reviewboard.kde.org/r/2271/diff
> 
> 
> Testing
> -------
> 
> Changed all colors using a pre patch version of KMail. Using this kmailrc file with a patched version of KMail shows all color changed in the settings dialog.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/