[Kde-pim] Review Request: Change to the ldap library to allow paging of search results

[eaton.mark at gmail.com]

> On 2009-11-20 10:51:31, Kevin Krammer wrote:
> > /branches/KDE/4.3/kdepimlibs/kldap/ldapsearch.cpp, line 222
> > <http://reviewboard.kde.org/r/2212/diff/1/?file=14692#file14692line222>
> >
> >     Is this value defined somewhere? As in #define or enum?
> >

well it is #defined in ldap.h from OpenLDAP, but for reasons that escape me the rest of the kldap codebase seems to avoid
using the defines from here.


- marke


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2212/#review3177
-----------------------------------------------------------


On 2009-11-19 11:16:44, marke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2212/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 11:16:44)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If a search will return a large number of results paging of the results is desirable and for some server configurations necessary.
> This patch allows paging of results to work with the kldap library.
> It does this by
> 1. preventing duplicate paging controls from being added. This was causing the server to reject the search as invalid.
> 2. disabling automatic following of references from the server. When references are followed the paging response is never processed.
> 3. Ignoring the reference messages the server sends since the library errors when it receives one.
> 
> Potentially an additional signal/slot could be added to handle references but I can't see a usecase for this so I haven't implemented
> it here.
> 
> 
> This addresses bug 215190.
>     https://bugs.kde.org/show_bug.cgi?id=215190
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapcontrol.h 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapcontrol.cpp 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapoperation.cpp 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapsearch.cpp 1051265 
> 
> Diff: http://reviewboard.kde.org/r/2212/diff
> 
> 
> Testing
> -------
> 
> I have been testing this against the company Active Directory server with the akonadi agent I'm developing and it handles the ~70,000 contacts correctly with the patch. Without the patch
> AD will only return 1000 results (this is the AD default setup).
> 
> 
> Thanks,
> 
> marke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/