[Kde-pim] Review Request: kolabproxyresource.cpp:404: warning: unused variable 'job'

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2172/
-----------------------------------------------------------

(Updated 2009-11-15 15:11:46.658986)


Review request for KDE PIM.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=
reports:
/.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:404: warning: unused variable 'job'
/.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:420: warning: unused variable 'job'
/.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:499: warning: unused variable 'job'
/.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:552: warning: unused variable 'job'

my proposal: in the four functions, the variable is only declared and get some memory: is it realy
             necessary?
             If not, one can delete the lines
see: kolabproxyresource-gm-65.diff


Diffs (updated)
-----

  /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp 1046400 

Diff: http://reviewboard.kde.org/r/2172/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/