[Kde-pim] Review Request: test_cryptoconfig.cpp:75: warning: enumeration value 'NumArgType' not handled in switch

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1907/#review3021
-----------------------------------------------------------

Ship it!


Please put the first chunk to the end of the switch statement and add a comment that those particular values are just metadata and should never actually occur in the switch.

- Stephen


On 2009-10-19 18:38:34, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1907/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 18:38:34)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/libkleo/tests/test_cryptoconfig.cpp:75: warning: enumeration value 'NumArgType' not handled in switch
> /.../kdepim/libkleo/tests/test_cryptoconfig.cpp:99: warning: enumeration value 'NumArgType' not handled in switch
> 
> at
> int main( int argc, char** argv ) {
> 
> my proposal: add the enumeration value 'NumArgType' in the two switches
> see: test_cryptoconfig-gm-22
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkleo/tests/test_cryptoconfig.cpp 1031659 
> 
> Diff: http://reviewboard.kde.org/r/1907/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/