[Kde-pim] Review Request: test_kmime_codec.cpp:414: warning: suggest explicit braces to avoid ambiguous 'else'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2127/#review3005
-----------------------------------------------------------

Ship it!


Looks ok to me.

- Stephen


On 2009-11-10 16:14:49, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2127/
> -----------------------------------------------------------
> 
> (Updated 2009-11-10 16:14:49)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> ============
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepimlibs/kmime/tests/test_kmime_codec.cpp:414: warning: suggest explicit braces to avoid ambiguous 'else'
> 
> at
> encode_decode_chunkwise
> 
> my proposal: complete with some more parentheses
> see: test_kmime_codec-gm-49.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kmime/tests/test_kmime_codec.cpp 1045694 
> 
> Diff: http://reviewboard.kde.org/r/2127/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/