[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-11-11 20:19:41.478090)


Review request for KDE PIM.


Changes
-------

Renamed MultipartNormal to MultipartPlain in htmlstatusbar.h and htmlstatusbar.cpp.
Renamed setToggleDisplayMode to setToggleHtmlMode in kmreaderwin.h and kmreaderwin.cpp.
Changed status bar text for multi-part messages to more appropriately say "HTML Message" and "Plain Message" instead of "HTML Message Part" and "No HTML Message Part."
Changed where HTML status bar mode is set from kmreaderwin to ObjectTreeParser in order to work with multi-part messages of different message structures.

Tested with messages of types:
plain text
html
plain text and html
plain text and html with embedded images
plain text with attachments
plain text and html with attachments
encrypted plain text and html


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445 
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445 
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445 
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445 
  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445 

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/