[Kde-pim] Review Request: Change to the ldap library to allow paging of search results

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2212/#review3218
-----------------------------------------------------------


Thanks for your feedback.
I'd say use the #define instead of the hardcoded value, no point in more hardcoding even if it used to be done in the past.

IMHO the method name should still be more like addOrReplaceControl or updateUniqueControl, etc.

I am not sure what our policies say about adding methods to public interfaces in stable branches, e.g. in trunk it would have to be marked with @since 4.4

- Kevin


On 2009-11-19 11:16:44, marke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2212/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 11:16:44)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If a search will return a large number of results paging of the results is desirable and for some server configurations necessary.
> This patch allows paging of results to work with the kldap library.
> It does this by
> 1. preventing duplicate paging controls from being added. This was causing the server to reject the search as invalid.
> 2. disabling automatic following of references from the server. When references are followed the paging response is never processed.
> 3. Ignoring the reference messages the server sends since the library errors when it receives one.
> 
> Potentially an additional signal/slot could be added to handle references but I can't see a usecase for this so I haven't implemented
> it here.
> 
> 
> This addresses bug 215190.
>     https://bugs.kde.org/show_bug.cgi?id=215190
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapcontrol.h 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapcontrol.cpp 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapoperation.cpp 1051265 
>   /branches/KDE/4.3/kdepimlibs/kldap/ldapsearch.cpp 1051265 
> 
> Diff: http://reviewboard.kde.org/r/2212/diff
> 
> 
> Testing
> -------
> 
> I have been testing this against the company Active Directory server with the akonadi agent I'm developing and it handles the ~70,000 contacts correctly with the patch. Without the patch
> AD will only return 1000 results (this is the AD default setup).
> 
> 
> Thanks,
> 
> marke
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/