[Kde-pim] Review Request: Use KMime::Message::Ptr in stead of raw KMime::Message*.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2193/#review3154
-----------------------------------------------------------

Ship it!


Thomas is of course right that this leads to ugly code when connecting raw pointer and shared pointer using components, but we have that now already and this is a step into the right direction. So, please commit :)

- Volker


On 2009-11-17 15:18:12, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2193/
> -----------------------------------------------------------
> 
> (Updated 2009-11-17 15:18:12)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Change KMComposerWin api to use KMime::Message::Ptr in stead of raw KMime::Message*.
> 
> 
> Diffs
> -----
> 
>   branches/work/akonadi-ports/kdepim/kmail/kmkernel.cpp 1050481 
>   branches/work/akonadi-ports/kdepim/kmail/kmcommands.cpp 1050499 
>   branches/work/akonadi-ports/kdepim/kmail/composer.h 1050481 
>   branches/work/akonadi-ports/kdepim/kmail/kmmainwidget.cpp 1050481 
>   branches/work/akonadi-ports/kdepim/kmail/mailserviceimpl.cpp 1050481 
>   branches/work/akonadi-ports/kdepim/kmail/newcomposerwin.h 1050481 
>   branches/work/akonadi-ports/kdepim/kmail/newcomposerwin.cpp 1050481 
> 
> Diff: http://reviewboard.kde.org/r/2193/diff
> 
> 
> Testing
> -------
> 
> Saving a draft in the akonadi-ports branch now sort of works. As in, this fixes the crash that happend due to an Message::Ptr going out of scope and the raw pointer being used afterwards.
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/