[Kde-pim] Review Request: kncomposer.cpp:399: warning: unused variable 'numLines'

Bertjan Broeksema b.broeksema at home.nl
Wed Nov 25 20:04:26 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2182/#review3282
-----------------------------------------------------------


I don't see a valid reason for this patch. Probably it would be better to contact laurent to see I you can come up with a real fix.

- Bertjan


On 2009-11-25 17:49:06, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2182/
> -----------------------------------------------------------
> 
> (Updated 2009-11-25 17:49:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/knode/kncomposer.cpp:399: warning: unused variable 'numLines'
> 
> at
> KNComposer::KNComposer
> 
> my proposal: comment the line out until "Laurent fix me"
> see: kncomposer-gm-69.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/kncomposer.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2182/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list