[Kde-pim] Review Request: amazingcompleter.cpp:115: warning: unused parameter 'end', 'parent', 'start' and 'handler'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2217/#review3194
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/akonadi_next/amazingcompleter.cpp
<http://reviewboard.kde.org/r/2217/#comment2542>

    Please make these one per line.



/trunk/KDE/kdepim/akonadi/akonadi_next/amazingcompleter.cpp
<http://reviewboard.kde.org/r/2217/#comment2544>

    Please do not commit this line.
    
    This is code that is not yet complete, so the warning is valid.


- Stephen


On 2009-11-19 18:16:08, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2217/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 18:16:08)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> the dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'end'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'parent'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:115: warning: unused parameter 'start'
> /.../kdepim/akonadi/akonadi_next/amazingcompleter.cpp:137: warning: unused parameter 'handler'
> 
> my proposal: add some Q_UNUSED( )
> see: amazingcompleter-gm-84.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/akonadi_next/amazingcompleter.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/