[Kde-pim] Review Request: incidencehandler.cpp:113: warning: unused variable 'localIncidence'

[Stephen Kelly]

> On 2009-11-14 18:35:26, Kevin Krammer wrote:
> > Technically correct, however I think the intent was to use localIncidence instead of "local" and addedIncidence instead of inc.get()
> 
> Guy Maurel wrote:
>     OK.
>     To make clear that the variables are needed, I propose to split the declaration line into two lines.

Although that might silence the warnings, it is not the correct fix. Those variables are not needed. There is no need to trivially use them to silence the warnings.

Either remove the local variables, or use them as Kevin suggested by using

 addedIncidence = inc.get();

and using addedIncidence instead of calls to inc.get() in multiple places in the method.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2171/#review3085
-----------------------------------------------------------


On 2009-11-15 15:35:06, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2171/
> -----------------------------------------------------------
> 
> (Updated 2009-11-15 15:35:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/incidencehandler.cpp:113: warning: unused variable 'localIncidence'
> /.../kdepim/akonadi/resources/kolabproxy/incidencehandler.cpp:114: warning: unused variable 'addedIncidence'
> 
> at
> OIncidenceHandler::resolveConflict
> 
> my proposal: delete the lines
> see: incidencehandler-gm-64.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidencehandler.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2171/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/