[Kde-pim] Review Request: signencryptfilescontroller.cpp:140: warning: suggest explicit braces to avoid ambiguous 'else'

Guy Maurel guy-kde at maurel.de
Tue Nov 10 17:50:29 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2129/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdepim/kleopatra/crypto/signencryptfilescontroller.cpp:140: warning: suggest explicit braces to avoid ambiguous 'else'
/.../kdepim/kleopatra/crypto/signencryptfilescontroller.cpp:146: warning: suggest explicit braces to avoid ambiguous 'else'

at
SignEncryptFilesController::Private::titleForOperation

my proposal: complete with some more parentheses
see: signencryptfilescontroller-gm-51.diff


Diffs
-----

  /trunk/KDE/kdepim/kleopatra/crypto/signencryptfilescontroller.cpp 1046400 

Diff: http://reviewboard.kde.org/r/2129/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list