[Kde-pim] Review Request: "USE dbname" is mysql-specific

[Kevin Krammer]

> On 2009-11-12 09:24:46, Bertjan Broeksema wrote:
> > /trunk/kdesupport/akonadi/server/src/akonadi.cpp, line 406
> > <http://reviewboard.kde.org/r/2135/diff/1/?file=14346#file14346line406>
> >
> >     This looks a bit strange to me. First you set databaseName to a null string and than call open(). How can that work in the first place?

The test for an existing database is the open() in line 395.
This open() is the one for creating a database since the test in 395 failed.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2135/#review3046
-----------------------------------------------------------


On 2009-11-11 14:51:29, Yury Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2135/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 14:51:29)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Postgresql doesn't understand "USE akonadi", so using QtSql setDatabaseName() instead.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/akonadi.cpp 1047584 
> 
> Diff: http://reviewboard.kde.org/r/2135/diff
> 
> 
> Testing
> -------
> 
> I've tested with Postgresql and existing akonadi db.
> 
> 
> Thanks,
> 
> Yury
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/