[Kde-pim] Review Request: nntpresource.cpp:220: warning: unused variable 'append'

Kevin Krammer kevin.krammer at gmx.at
Sat Nov 14 18:25:08 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2173/#review3082
-----------------------------------------------------------


Also incorrect, see http://reviewboard.kde.org/r/2172/

- Kevin


On 2009-11-14 18:14:02, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2173/
> -----------------------------------------------------------
> 
> (Updated 2009-11-14 18:14:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/nntp/nntpresource.cpp:220: warning: unused variable 'append'
> /.../kdepim/akonadi/resources/nntp/nntpresource.cpp:236: warning: unused variable 'modify'
> 
> my proposal: in the two functions, the variable is only declared and get some memory: is it realy
>              necessary?
>              If not, one can delete the lines
> see: nntpresource.-gm-66.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/nntp/nntpresource.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list