[Kde-pim] Review Request: configdialog.cpp:98: warning: unused parameter 'error'

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2221/#review3172
-----------------------------------------------------------

Ship it!


The error could potentially be useful, but commit anyway. Maybe add a TODO comment like "should error be shown to the user?"

- Kevin


On 2009-11-19 18:42:58, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2221/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 18:42:58)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/microblog/configdialog.cpp:98: warning: unused parameter 'error'
> 
> at
> ConfigDialog::slotAuthFailed
> 
> my proposal: add Q_UNUSED( )
> see: configdialog-gm-88.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/microblog/configdialog.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2221/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/