[Kde-pim] Review Request: Add support for X- parameters in ICal entries

[Kevin Krammer]

> On 2009-11-08 22:36:19, David Jarvie wrote:
> > Couldn't this be done as in other libkcal classes, by deriving from CustomProperties? IncidenceBase, Alarm and Calendar classes all handle X- properties this way - it would be better to follow the same method for consistency, unless there's a good reason to do it some other way.
> 
> Kevin Krammer wrote:
>     Can't change the inheritance hierachy during KDE4 (BIC).
>     
>     Also, I am not sure the inheritance is good style, looks like convenience inheritance to me (not really an is-a relationship).
>     For KDE5 we might want to have CustomProperties as composition, which would also get rid of the @warning on assignment and equality operator
> 
> David Jarvie wrote:
>     Of course, you're right about BIC.
>     
>     Perhaps it would be a good idea, rather than implementing code specific to the Attendee class, to create a new generic way to do this. In KDE4, this can only be used for Attendee, but would replace CustomProperties for IncidenceBase, Alarm and Calendar in KDE5.

KABC probably has similar needs as well, i.e. for VCard custom properties.

Probably something like ExtensionAttributes, with a change observer instead of the virtual method.

Hmm, I wonder whether this could be done in KDE4 and CustomProperties internally "rebased"


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2093/#review2987
-----------------------------------------------------------


On 2009-11-08 13:24:04, Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2093/
> -----------------------------------------------------------
> 
> (Updated 2009-11-08 13:24:04)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1.
> These parameters are not processed by KCal and should be loaded and saved as-is, without further processing.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 
>   /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 
>   /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 
> 
> Diff: http://reviewboard.kde.org/r/2093/diff
> 
> 
> Testing
> -------
> 
> Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry.
> 
> 
> Thanks,
> 
> Grégory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/