[Kde-pim] Review Request: mailreaderview.cpp:81: warning: unused parameter 'button'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2231/#review3201
-----------------------------------------------------------


Please commit the Q_UNUSED, and instead of adding the #warning (with typo :)), and TODO as you wrote it, add a TODO something like "Handle click". 

As this is an example application, it is up to consumers of the library to decide how/whether such clicks should be handled in applications (eg, by passing them to KRun).

While you are there, it would be a good idea to change the int in the signal to a Qt::MouseButton (in the Viewer class) please file a separate review request for that if you try it. 

- Stephen


On 2009-11-20 17:12:16, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2231/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 17:12:16)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/examples/mailreader/mailreaderview.cpp:81: warning: unused parameter 'button'
> 
> at
> mailreaderView::urlClicked
> 
> my proposal: add Q_UNUSED( )
> see: mailreaderview-gm-91.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/examples/mailreader/mailreaderview.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2231/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/