[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

> On 2009-11-14 18:38:55, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp, line 114
> > <http://reviewboard.kde.org/r/2017/diff/3/?file=14361#file14361line114>
> >
> >     That's the same as in the HTML case, right?
> >     Then you can do:
> >     case Html:
> >     case MultipartHtml:
> >       bla
> >     
> >     To save some code duplication.

Thanks, I really should have caught this.


> On 2009-11-14 18:38:55, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/objecttreeparser.cpp, line 1269
> > <http://reviewboard.kde.org/r/2017/diff/3/?file=14364#file14364line1269>
> >
> >     Just because we're in processTextPlainSubtype() doesn't mean the entire mail is a plain text mail, unfortunatley.
> >     
> >     Just imagine the following mail structure:
> >     
> >     |-multipart/alternative
> >     | |-text/html
> >     | \-text/plain
> >     |-text/plain
> >     
> >     This structure happens, for example, when someone writes a HTML mail and the mailing list adds a plain text footer to it.
> >     
> >     The footer is processed last, so the colorbar would indicate a plain text message here, even though it is a HTML one.

I'm thinking this line is redundant anyways. Originally, the status bar was set to a neutral mode before a message was ever processed. If the the status bar was set to neutral after the message was processed, it was set to normal mode. I changed it to just assume normal mode and have it change appropriately when the message is processed. Do you think that would work okay?

I'm trying to craft a message with a message structure like you described to confirm it works as intended.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3083
-----------------------------------------------------------


On 2009-11-11 20:19:41, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 20:19:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445 
> 
> Diff: http://reviewboard.kde.org/r/2017/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/