[Kde-pim] Review Request: decryptverifytask.cpp:282: warning: 'const char * iconForSignature ...' defined but not used

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2149/#review3091
-----------------------------------------------------------

Ship it!


Simply remove the functions instead of commenting them out, that is much cleaner. And we have a version control system to get the functions back should they be needed.

Please commit afterwards.

- Thomas


On 2009-11-12 18:05:25, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2149/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 18:05:25)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kleopatra/crypto/decryptverifytask.cpp:282: warning: 'const char * iconForSignature ...' defined but not used
> /.../kdepim/kleopatra/crypto/decryptverifytask.cpp:290: warning: 'QColor color ... ' defined but not used
> /.../kdepim/kleopatra/crypto/decryptverifytask.cpp:298: warning: 'QColor color ... ' defined but not used
> 
> my proposal: as this functions are not defined in the decryptverifytask.h, comment them out, until someone needs them.
> see: decryptverifytask-gm-60.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/crypto/decryptverifytask.cpp 1047639 
> 
> Diff: http://reviewboard.kde.org/r/2149/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/