[Kde-pim] Review Request: resourceremote.cpp:193: warning: unused parameter 'percent'

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2236/#review3203
-----------------------------------------------------------


Please just add the Q_UNUSED() statement - omit the #warning and TODO. The reason for the function is that a progress dialogue might eventually be shown, at which time the function would be needed.

- David


On 2009-11-20 17:36:03, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2236/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 17:36:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kalarm/resources/resourceremote.cpp:193: warning: unused parameter 'percent'
> 
> at
> KAResourceRemote::slotPercent
> 
> my proposal: add Q_UNUSED( )
> see: resourceremote-gm-94.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kalarm/resources/resourceremote.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2236/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/