[Kde-pim] Review Request: locale.cpp:132: warning: unused variable 'codec'

[Guy Maurel]

> On 2009-11-15 16:06:36, Kevin Krammer wrote:
> > I think you can remove the variable and just ignore the return value of KGlobal::charsets()->codecForName(), i.e. only use it for checking the codec availability which is indicated by "ok".
> > 
> > Ideally there would be a toMimeCharset() overload which takes a codec so code like this does not have to do the lookup twice.
> >

OK, a little bit better
see: locale-gm-70-a.diff


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2183/#review3106
-----------------------------------------------------------


On 2009-11-15 15:55:00, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2183/
> -----------------------------------------------------------
> 
> (Updated 2009-11-15 15:55:00)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/knode/utils/locale.cpp:132: warning: unused variable 'codec'
> 
> at
> Locale::encodings
> 
> my proposal: split the line into two lines, so everyone can see that "codec"
>              is needed and "ok" at the "if(..."
> see: locale-gm-70.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/utils/locale.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2183/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/