[Kde-pim] Review Request: Build fix - Link to libexecinfo on FreeBSD when necessary

[Raphael Kubo da Costa]

> On 2009-11-21 07:50:27, Dima Panov wrote:
> > Index: CMakeLists.txt
> > ===================================================================
> > --- CMakeLists.txt      (revision 1051744)
> > +++ CMakeLists.txt      (working copy)
> > @@ -129,7 +128,14 @@
> > 
> >  ############### Configure checks ###############
> > 
> > +FIND_PATH( EXECINFO_INCLUDE_DIR "execinfo.h" )
> > +LIST (APPEND CMAKE_REQUIRED_INCLUDES ${EXECINFO_INCLUDE_DIR})
> >  check_include_files(execinfo.h HAVE_EXECINFO_H)
> > +find_library(EXECINFO_LIBRARY NAMES execinfo)
> > +if (EXECINFO_LIBRARY STREQUAL "EXECINFO_LIBRARY-NOTFOUND")
> > +  set(EXECINFO_LIBRARY "")
> > +endif (EXECINFO_LIBRARY STREQUAL "EXECINFO_LIBRARY-NOTFOUND")
> > +
> >  check_include_files(unistd.h HAVE_UNISTD_H)
> > 
> >  # set the output paths
> >

As we've just discussed on IRC, I think it's better not to use FIND_PATH and LIST here (Alex may prove me wrong): it's up to FreeBSD's ports system to make sure CPATH includes /usr/local/include, so that the header is properly found.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2255/#review3217
-----------------------------------------------------------


On 2009-11-23 02:21:34, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2255/
> -----------------------------------------------------------
> 
> (Updated 2009-11-23 02:21:34)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> At least on FreeBSD, execinfo isn't provided directly by libc, but by a separate port/package which, besides providing execinfo.h, also has a libexecinfo to link to when using functions such as backtrace().
> 
> This patch looks for libexecinfo and adds it to the libraries used to link akonadiprivate when necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/CMakeLists.txt 1052935 
>   /trunk/kdesupport/akonadi/server/CMakeLists.txt 1052935 
>   /trunk/kdesupport/akonadi/server/akonadictl/CMakeLists.txt 1052935 
>   /trunk/kdesupport/akonadi/server/control/CMakeLists.txt 1052935 
> 
> Diff: http://reviewboard.kde.org/r/2255/diff
> 
> 
> Testing
> -------
> 
> After the changes, a FreeBSD build of akonadi with execinfo installed has succeeded.
> 
> 
> Thanks,
> 
> Raphael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/