[Kde-pim] Review Request: Support for message indicator in KMail

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2060/#review2931
-----------------------------------------------------------


As much as I would like this patch to go (note: I didn't review it, but I think the feature is useful) in I'm not sure whether it's worth it because:
a) In view of Akonadi your patch needs to be rewritten based on Akonadi. The message indicator stuff does not belong into KMail. Instead you should implement it as message indicator Akonadi agent.
b) Porting KMail to Akonadi happens on a work branch. Your patch would increase the difference between trunk and this work branch. Consequently, it would make merging of bug fixes from trunk to the Akonadi-port work branch a bit more difficult.

In the end Thomas needs to decide.

- Ingo


On 2009-11-04 14:33:09, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2060/
> -----------------------------------------------------------
> 
> (Updated 2009-11-04 14:33:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch adds optional support for message indicator to KMail. For more information about message indicators, have a look at this blog post: http://agateau.wordpress.com/2009/09/18/indicators-notifications-and-co/
> 
> You need libindicate and libindicate-qt installed to build it. You also need the indicator plasmoid at runtime otherwise you won't see anything interesting.
> - http://launchpad.net/libindicate
> - http://launchpad.net/libindicate-qt
> - http://launchpad.net/plasma-indicatordisplay
> 
> The patch is quite large, it is also available as more incremental steps here if you find this easier to read: http://people.canonical.com/~agateau/indicate/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/CMakeLists.txt 1044435 
>   trunk/KDE/kdepim/kmail/config-kmail.h.cmake 1044435 
>   trunk/KDE/kdepim/kmail/configuredialog.cpp 1044435 
>   trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1044435 
>   trunk/KDE/kdepim/kmail/kmfolder.h 1044435 
>   trunk/KDE/kdepim/kmail/kmfolder.cpp 1044435 
>   trunk/KDE/kdepim/kmail/kmkernel.h 1044435 
>   trunk/KDE/kdepim/kmail/kmkernel.cpp 1044435 
>   trunk/KDE/kdepim/kmail/ui/accountspagereceivingtab.ui 1044435 
> 
> Diff: http://reviewboard.kde.org/r/2060/diff
> 
> 
> Testing
> -------
> 
> This patch has been in use during Kubuntu Karmic development and is now deployed with Kubuntu Karmic version of KMail (kdepim 4.3.2 at the time of this writing).
> 
> 
> Thanks,
> 
> Aurélien
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/