[Kde-pim] Review Request: alarmresources.cpp:740: warning: unused parameter 'percent'
David Jarvie
djarvie at kde.org
Fri Nov 20 17:41:30 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2235/#review3200
-----------------------------------------------------------
These two functions should just be removed. Also, the conditionally compiled (#if 0) reference to slotResourceDownloading() should be removed.
- David
On 2009-11-20 17:29:09, Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2235/
> -----------------------------------------------------------
>
> (Updated 2009-11-20 17:29:09)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> The dashboard
> http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kalarm/resources/alarmresources.cpp:740: warning: unused parameter 'percent'
> /.../kdepim/kalarm/resources/alarmresources.cpp:740: warning: unused parameter 'resource'
> /.../kdepim/kalarm/resources/alarmresources.cpp:816: warning: unused parameter 'resource'
>
> my proposal: add some Q_UNUSED( )
> see: alarmresources-gm-93.diff
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/kalarm/resources/alarmresources.cpp 1046400
>
> Diff: http://reviewboard.kde.org/r/2235/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list