[Kde-pim] Review Request: a typo? certificateselectiondialog.cpp:146: warning: unused variable 'cancel'

[Guy Maurel]

> On 2009-11-14 18:32:50, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/kleopatra/dialogs/certificateselectiondialog.cpp, line 158
> > <http://reviewboard.kde.org/r/2175/diff/1/?file=14488#file14488line158>
> >
> >     QPushButton doesn't have a rejected() signal.
> >     It might be equivalent to use its clicked() signal, but even if it is it will be more readable to ahve both accept and reject handled by the buttonBox instead by specific buttons.
> >     
> >     I would recommend using
> >     Q_UNUSED( cancel ) instead

OK


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2175/#review3084
-----------------------------------------------------------


On 2009-11-14 18:17:51, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2175/
> -----------------------------------------------------------
> 
> (Updated 2009-11-14 18:17:51)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/dialogs/certificateselectiondialog.cpp:146: warning: unused variable 'cancel'
> 
> at
> class CertificateSelectionDialog::Private
> 
> my proposal: It could be a typo at line 156:
>                connect( &buttonBox, SIGNAL(rejected()), q, SLOT(reject()) );
>              which migth be:
>                connect( cancel, SIGNAL(rejected()), q, SLOT(reject()) );
>              what thinks the developper of it?
> 
> see: certificateselectiondialog-gm-68.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/dialogs/certificateselectiondialog.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2175/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/