[Kde-pim] Review Request: kolabproxyresource.cpp:404: warning: unused variable 'job'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2172/#review3315
-----------------------------------------------------------


There are still a few jobs started without connecting to their result slot. See for example the imapCollectionRemoved method. It would be good to fix those too.


/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2595>

    Should move to the result slot.



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2596>

    Should move to the result slot.



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2598>

    Indeed. It looks like that to me too.
    
    Just remove the cancelTask line.
    



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp
<http://reviewboard.kde.org/r/2172/#comment2599>

    No need for this method at all. Just connect the job to the existing kolabFolderChangeResult.


- Stephen


On 2009-11-26 20:18:47, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2172/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 20:18:47)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:404: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:420: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:499: warning: unused variable 'job'
> /.../kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp:552: warning: unused variable 'job'
> 
> my proposal: in the four functions, the variable is only declared and get some memory: is it realy
>              necessary?
>              If not, one can delete the lines
> see: kolabproxyresource-gm-65.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.h 1053258 
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/kolabproxyresource.cpp 1053258 
> 
> Diff: http://reviewboard.kde.org/r/2172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/