[Kde-pim] Review Request: decryptverifycommandemailbase.cpp:175: warning: suggest explicit braces to avoid ambiguous 'else'

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2141/#review3089
-----------------------------------------------------------

Ship it!


Seems fine, please commit.

I don't think you need a review request for all those warnings about explicit braces, those are kind of obvious. Please commit without asking for those.
Same for parenthesis around && and || (although you need to double-check here that it is really intended and not a bug in the original code).

So please commit and close all review requests that deal with those two kind of warnings.

- Thomas


On 2009-11-11 18:47:22, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2141/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 18:47:22)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kleopatra/uiserver/decryptverifycommandemailbase.cpp:175: warning: suggest explicit braces to avoid ambiguous 'else'
> /.../kdepim/kleopatra/uiserver/decryptverifycommandemailbase.cpp:183: warning: suggest explicit braces to avoid ambiguous 'else'
> 
> at
> DecryptVerifyCommandEMailBase::Private::checkForErrors
> 
> my proposal: complete with some more parentheses
> see: decryptverifycommandemailbase-gm-53.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/uiserver/decryptverifycommandemailbase.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2141/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/