[Kde-pim] Review Request: Enable setting of background color by message tag.

Jonathan Armond jon.armond at gmail.com
Sun May 31 15:06:12 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/783/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Added control to set a background color to the message tag tab in the configure dialog. Color is stored in message item and is checked for validity when drawing the message item control.

Some duplicated code from StorageModel put into new functions.


This addresses bug 50409.
    https://bugs.kde.org/show_bug.cgi?id=50409


Diffs
-----

  /trunk/KDE/kdepim/kmail/configuredialog.cpp 975782 
  /trunk/KDE/kdepim/kmail/configuredialog_p.h 975782 
  /trunk/KDE/kdepim/kmail/kmmessagetag.cpp 975782 
  /trunk/KDE/kdepim/kmail/messagelistview/core/messageitem.h 975841 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themedelegate.cpp 975841 
  /trunk/KDE/kdepim/kmail/messagelistview/storagemodel.cpp 975841 

Diff: http://reviewboard.kde.org/r/783/diff


Testing
-------

Can create new tags with background colors. Assigning tags to messages causes background color to display. Can remove color from tag.

NB still have to exit and re-enter a folder to see changes to tag properties (issue unrelated to this patch)


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list