[Kde-pim] Review Request: Update Identities after renaming sending accounts

[Ingo Klöcker]

> On 2009-05-26 12:31:50, Ingo Klöcker wrote:
> > I suggest to add a local recursion guard to TransportManager::slotTransportsChanged():
> > 
> > void TransportManager::slotTransportsChanged()
> > {
> >   static bool alreadyHere = false;
> >   if ( alreadyHere ) {
> >     // we have been called recursively -> do nothing
> >     return;
> >   }
> >   kDebug();
> >   d->config->reparseConfiguration();
> >   // FIXME: this deletes existing transport objects!
> >   readConfig();
> >   alreadyHere = true;
> >   emit transportsChanged();
> >   alreadyHere = false;
> > }
> 
> Ingo Klöcker wrote:
>     Do this change additionally to your changes.

Hmm, I thought about this again. My proposal prevents a synchronous signal-slot recursion, but slotTransportsChanged() is connected to a D-Bus signal and I guess this is not emitted/received synchronously, but asynchronously. To prevent against such a recursion one would have to check the sender of the D-Bus signal and ignore the signal if we have sent it ourselves. I have no idea how to do this or whether this is even possible.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/765/#review1209
-----------------------------------------------------------


On 2009-05-26 14:55:08, Frank Thieme wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/765/
> -----------------------------------------------------------
> 
> (Updated 2009-05-26 14:55:08)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Solves the bug 185069. As myOwnChanged is just used on this place, it shouldn't have any side effects.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/mailtransport/transportmanager.cpp 973225 
> 
> Diff: http://reviewboard.kde.org/r/765/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/