[Kde-pim] Review Request: Improve error message when sending without an account
Jonathan Armond
jon.armond at gmail.com
Tue May 26 11:35:30 BST 2009
> On 2009-05-26 03:02:36, Frank Osterfeld wrote:
> > You need to pass w to the dialog instead of 0. That's necessary for correct window stacking. Also, the dialog is currently leaked, so unless w is granted to be temporary, too, better set Qt::WA_DeleteOnClose.
Good point about WA_DeleteOnClose, for some reason I assumed it would be set by default.
If I send w to the dialog, it just paints the widgets without a background over the compose window. Perhaps I should do a raise()?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/762/#review1201
-----------------------------------------------------------
On 2009-05-26 02:39:22, Jonathan Armond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/762/
> -----------------------------------------------------------
>
> (Updated 2009-05-26 02:39:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Error message when sending with no outgoing account changed to a question asking whether user wants to create one now. If yes, opens the transport management widget to create outgoing account.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/kmail/util.cpp 972508
>
> Diff: http://reviewboard.kde.org/r/762/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list