[Kde-pim] Review Request: Make sure that namespace get stored when set to <empty>

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/681/#review1094
-----------------------------------------------------------

Ship it!


Looks fine for me (but I didn't test this). Please commit.

- Thomas


On 2009-05-09 06:25:31, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/681/
> -----------------------------------------------------------
> 
> (Updated 2009-05-09 06:25:31)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> One of my imap account is set to the namespace name ~ for the "Other Users" namespace which contains the inbox and all folders etc. when I click the refresh button. When I click on the edit button and then in the namespace edit dialog on the remove button, the namespace didn't get stored in the config file. I think this is because the map is made empty and the KConfig framework doesn't do anything with it in that case. This small patch adds one entry to the map if it is empty (not sure if the check for emptyness is needed). This fixes my problem of this setting not getting stored.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/accountdialog.cpp 965325 
> 
> Diff: http://reviewboard.kde.org/r/681/diff
> 
> 
> Testing
> -------
> 
> Set the namespace to an empty value by clicking on the edit button in the account settings dialog for the "other users" namespace and than on the remove button in the edit namespace dialog. Ok, ok to close the dialogs and save the settings. -> Checked the ~/.kde4/share/config/kmailrc for the setting and it was changed after my patch, while it didn't change before the patch.
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/