[Kde-pim] Cyclic link dependencies in kdepimlibs - how to resolve?

[Thomas McGuire]

Hi,

On Tuesday 05 May 2009 12:30:18 Volker Krause wrote:
> On Tuesday 05 May 2009 01:16:23 Ingo Klöcker wrote:
> > On Tuesday 05 May 2009, Thomas McGuire wrote:
> > > now that KPIMTextEdit is basically complete, I wanted to support
> > > images in signatures.
> > > The signature editor is in kpimidentities, so kpimidentities needs to
> > > link to kpimtextedit so that the signature editor there can support
> > > images.
> > >
> > > Problem is, kpimtextedit already links to kpimidentities, because it
> > > has some functions to insert signatures into the text edit.
> >
> > Why do those functions exist in kpimtextedit? Wouldn't it be sufficient
> > to have a method insertSignature() which is called by somebody (e.g.
> > KMail) who can link against both libraries?
>
> right, getting rid of these looks like the best way to solve this. Can't we
> move those to kpimidentities instead?

I think moving those methods to the Signature class in kpimidentities might 
indeed be the best idea, I'll try that.
If that doesn't work I'll move them back to kmeditor in libkdepim, but that 
would mean Mailody can't use these methods.

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090505/10410730/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/