[Kde-pim] Review Request: Fix international email fields from command line in KMail

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/688/#review1106
-----------------------------------------------------------

Ship it!


Looks fine to me, please commit.
Or tell me if you don't have commit access.

Thanks for the patch :)

- Thomas


On 2009-05-12 17:44:08, Miroslav Los wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/688/
> -----------------------------------------------------------
> 
> (Updated 2009-05-12 17:44:08)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Kmail allows to invoke a mail composer from the command line, with options and arguments specifying the to, cc and bcc fields.
> All these fields are processed as possibly RFC2047-encoded strings, due to the KToolInvocation::invokeMailer method 
> from kdelibs/kdecore/kernel/ktoolinvocation_x11.cpp. The strings are converted to latin1 early in the process, which is not 
> locale friendly. This bug appears in all current versions of kmail (could be easily fixed in 3.5, too).
> 
> I suggest to convert them to the local 8-bit encoding, as only the following can happen:
> a) if they are really encoded according to RFC2047, then they are ASCII, or
> b) they come from the command line (well, they always come from the command line), so they were in the local encoding in the first place.
> 
> The patch thus allows to invoke kmail with email fields like "Jo{U+017E}o U{U+017E}{U+00ED}vate{U+013E} <jozo at example.com>".
> 
> (with real characters, not code points, that is. Unicode support is missing in this reviewboard, too.)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmkernel.cpp 967238 
> 
> Diff: http://reviewboard.kde.org/r/688/diff
> 
> 
> Testing
> -------
> 
> Works for me (Slovak UTF-8 locale). I do not expect any problems with this.
> 
> 
> Thanks,
> 
> Miroslav
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/