[Kde-pim] Review Request: Improve error message when sending without an account

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/762/#review1239
-----------------------------------------------------------



/trunk/KDE/kdepimlibs/mailtransport/transportmanagementwidget.h
<http://reviewboard.kde.org/r/762/#comment771>

    Moving something from private to public is not binary compatible, see http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++
    (kdepimlibs needs to maintain binary compatibility, while kdepim does not)
    
    Please add a new public method instead which internally calls addClicked().
    Make sure the method is marked with @since 4.3 and has a little bit of API dox.


- Thomas


On 2009-05-26 12:43:50, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2009-05-26 12:43:50)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Error message when sending with no outgoing account changed to a question asking whether user wants to create one now. If yes, opens the transport management widget to create outgoing account.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/util.cpp 973014 
>   /trunk/KDE/kdepimlibs/mailtransport/transportmanagementwidget.h 972377 
> 
> Diff: http://reviewboard.kde.org/r/762/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/