[Kde-pim] Review Request: add AgentInstance::setOption method, to set an option via DBus

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/734/#review1170
-----------------------------------------------------------


It seems I don't get the general idea about this quite complex approach of constructing D-Bus method names.
If we require an interface to set arbitrary options, why not add one setOption(string, variant) method to the D-Bus interface?



/trunk/KDE/kdepimlibs/akonadi/agentinstance_p.h
<http://reviewboard.kde.org/r/734/#comment735>

    just a personal coding style thing, but I prefer using the initialization list.
    Makes all kinds of initialization look equal, i.e. for const and non-const members



/trunk/KDE/kdepimlibs/akonadi/agentinstance_p.h
<http://reviewboard.kde.org/r/734/#comment736>

    Don't both instances then delete the mInterface pointer?


- Kevin


On 2009-05-21 11:37:08, Constantin Berzan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/734/
> -----------------------------------------------------------
> 
> (Updated 2009-05-21 11:37:08)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This makes it possible to configure an agent / resource via DBus without having to go through the trouble of creating a QDBusInterface.  The code existed before in Firstrun, an internal class in kdepimlibs/akonadi.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/agentinstance.h 970429 
>   /trunk/KDE/kdepimlibs/akonadi/agentinstance.cpp 970429 
>   /trunk/KDE/kdepimlibs/akonadi/agentinstance_p.h 970429 
>   /trunk/KDE/kdepimlibs/akonadi/firstrun.cpp 970429 
>   /trunk/KDE/kdepimlibs/akonadi/firstrun_p.h 970429 
> 
> Diff: http://reviewboard.kde.org/r/734/diff
> 
> 
> Testing
> -------
> 
> * maildir resource creation and configuration from the outboxinterface lib in playground/pim (not commited to svn yet)
> * maildir resource creation and configuration via Firstrun, by putting a default file in ~/kde/share/apps/akonadi/firstrun.  Settings of type QString and bool have been tested.
> 
> 
> Thanks,
> 
> Constantin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/