[Kde-pim] Review Request: Fixing kaddressbook export for GMX
Allen Winter
winter at kde.org
Fri May 15 14:04:07 BST 2009
On Friday 15 May 2009 8:48:53 am Urs Joss wrote:
>
> > On 2009-05-13 16:18:22, Allen Winter wrote:
> > > Feel free to commit this.
> >
> > Urs Joss wrote:
> > Hi Allan
> >
> > This is my first contribution here and I'm not sure if you're directing the 'go' to me or not. Just in case: I don't have commit permissions and would have to rely on somebody who does have them to get this patch into trunk.
> >
> > Cheers
> > Urs
> >
> > Urs Joss wrote:
> > Thanks for submitting the patch, Allan
> >
> > Thomas McGuire wrote:
> > Allen, this patch probably needs to applied to KContactManager as well.
> > (Urs: KContactManager is an Akonadi-based replacement for KAddressbook which took much of the code base from KAddressbook)
>
> Allen (sorry for repeatedly calling you Allan), Thomas
>
> I stumbled on the same issue on the GMX import side (I had never personally used that functionality). But before I can provide that update I'll need to do some testing. Maybe we can bundle that before applying the bunch to KContactManager.
>
> How shall I proceed here, will this be a separate patch and request or shall I update the patch here (even though you have already applied it)?
>
A new patch on reviewboard will be fine.
Don't worry, we'll handle committing it to both kaddressbook and kcontactmanager.
... at least until you can do commit yourself :)
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list