[Kde-pim] Review Request: add AgentInstance::setOption method, to set an option via DBus

[Constantin Berzan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/734/
-----------------------------------------------------------

(Updated 2009-05-21 23:45:01.719307)


Review request for KDE PIM.


Changes
-------

* style: use initialization list instead of assignment in constructor
* prevent double deletion of mInterface.  It will simply not be passed on to new instances


Summary
-------

This makes it possible to configure an agent / resource via DBus without having to go through the trouble of creating a QDBusInterface.  The code existed before in Firstrun, an internal class in kdepimlibs/akonadi.


Diffs (updated)
-----

  /trunk/KDE/kdepimlibs/akonadi/agentinstance.h 970429 
  /trunk/KDE/kdepimlibs/akonadi/agentinstance.cpp 970429 
  /trunk/KDE/kdepimlibs/akonadi/agentinstance_p.h 970429 
  /trunk/KDE/kdepimlibs/akonadi/firstrun.cpp 970429 
  /trunk/KDE/kdepimlibs/akonadi/firstrun_p.h 970429 

Diff: http://reviewboard.kde.org/r/734/diff


Testing
-------

* maildir resource creation and configuration from the outboxinterface lib in playground/pim (not commited to svn yet)
* maildir resource creation and configuration via Firstrun, by putting a default file in ~/kde/share/apps/akonadi/firstrun.  Settings of type QString and bool have been tested.


Thanks,

Constantin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/