[Kde-pim] Review Request: Warn user filter without actions is invalid

[Jonathan Armond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/761/
-----------------------------------------------------------

(Updated 2009-05-26 12:02:03.810141)


Review request for KDE PIM.


Changes
-------

My fault I didn't read the earlier comment properly. Hopefully I've got it this time.

Warn user only when *both* criteria and actions are missing, or no accounts are selected.


Summary
-------

Current behaviour is to complain when saving a filter with no matching pattern, but having no action is allowed. This patch changes it complain if no action is specified or no matching pattern or, if applicable, no accounts are selected.


This addresses bug 182581.
    https://bugs.kde.org/show_bug.cgi?id=182581


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmfilter.cpp 973014 

Diff: http://reviewboard.kde.org/r/761/diff


Testing
-------


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/