[Kde-pim] Review Request: Delete Factory singletons?

Volker Krause vkrause at kde.org
Sat May 9 10:29:45 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/677/#review1091
-----------------------------------------------------------

Ship it!


Looks ok to me.

- Volker


On 2009-05-06 11:48:28, André Wöbbeking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/677/
> -----------------------------------------------------------
> 
> (Updated 2009-05-06 11:48:28)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> While valgrinding KOrganizer I had several leaks due to not freed Factories. This is probably no real leak as we're speaking about singletons but it makes finding the real leaks harder.
> 
> OK to commit?
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.2/kdepimlibs/kresources/factory.cpp 964030 
> 
> Diff: http://reviewboard.kde.org/r/677/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> André
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list