[Kde-pim] Review Request: Fix site favicons being squashed together in Akregator's feed list

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/668/
-----------------------------------------------------------

(Updated 2009-05-06 09:36:09.967234)


Review request for KDE PIM.


Changes
-------

Use an item delegate to control the items' size hint, painting and font, as suggested.

The row height plus a margin is calculated by the delegate, using the same algorithm as before.

A bold font, for feeds with unread articles, is selected while painting.  An additional item role 'HasUnreadRole' is added to the model data in order to retrieve this information in the delegate's paint() function.  Returning data for Qt::FontRole removed from the item model.


Summary
-------

Add some line spacing between Akregator's feed list rows, so that the site favicons do not run into each other.
Particularly noticeable in this application, because many sites' favicons are square with no margin.

Calculate the row height as the maximum of the current icon theme's "Small" size, and the font height
for the "General" font.  Return this, plus a 1-pixel margin, as the SizeHintRole for the list view model.
Recalculate this on a font or theme settings change.


This addresses bug 178821.
    https://bugs.kde.org/show_bug.cgi?id=178821


Diffs (updated)
-----

  /trunk/KDE/kdepim/akregator/src/subscriptionlistmodel.cpp 964216 
  /trunk/KDE/kdepim/akregator/src/subscriptionlistmodel.h 964216 
  /trunk/KDE/kdepim/akregator/src/subscriptionlistdelegate.cpp PRE-CREATION 
  /trunk/KDE/kdepim/akregator/src/CMakeLists.txt 964216 
  /trunk/KDE/kdepim/akregator/src/subscriptionlistdelegate.h PRE-CREATION 
  /trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 964216 

Diff: http://reviewboard.kde.org/r/668/diff


Testing
-------

Built and run Akregator application with these changes, checked on a variety of feed sites.


Thanks,

Jonathan

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/