[Kde-pim] Review Request: Fix site favicons being squashed together in Akregator's feed list

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/668/#review1058
-----------------------------------------------------------


I don't like that the model cares about view-specific settings (like the font used). Maybe it could be solved by implementing our own ItemDelegate like this:

class FeedListItemDelegate : public QItemDelegate {

    QSize sizeHint( ... ) const { /* return QItemDelegate::sizeHint() + padding */ }
    void paint( QPainter* p, ... ) { /* translate() painter by padding. call QItemDelegate::paint( p ). translate() back. }
};

Then the font and style handling is done by the delegate and not by the model. (It would be useful to have a custom delegate for the differently colored "title (unread count)" anyway).

- Frank


On 2009-05-04 01:42:52, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/668/
> -----------------------------------------------------------
> 
> (Updated 2009-05-04 01:42:52)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add some line spacing between Akregator's feed list rows, so that the site favicons do not run into each other.
> Particularly noticeable in this application, because many sites' favicons are square with no margin.
> 
> Calculate the row height as the maximum of the current icon theme's "Small" size, and the font height
> for the "General" font.  Return this, plus a 1-pixel margin, as the SizeHintRole for the list view model.
> Recalculate this on a font or theme settings change.
> 
> 
> This addresses bug 178821.
>     https://bugs.kde.org/show_bug.cgi?id=178821
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akregator/src/subscriptionlistmodel.h 961645 
>   /trunk/KDE/kdepim/akregator/src/subscriptionlistmodel.cpp 961645 
>   /trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 963187 
> 
> Diff: http://reviewboard.kde.org/r/668/diff
> 
> 
> Testing
> -------
> 
> Built and run Akregator application with these changes, checked on a variety of feed sites.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/